Skip to content

Unconstrained parameter fix#148788

Open
TomtheCoder2 wants to merge 21 commits intorust-lang:mainfrom
TomtheCoder2:unconstrained-parameter-fix
Open

Unconstrained parameter fix#148788
TomtheCoder2 wants to merge 21 commits intorust-lang:mainfrom
TomtheCoder2:unconstrained-parameter-fix

Conversation

@TomtheCoder2
Copy link

@TomtheCoder2 TomtheCoder2 commented Nov 10, 2025 •
edited by rustbot
Loading

View all comments

This PR is an attempt to solve the issue described in the issue #107295

@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2025

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
davidtwco
davidtwco requested changes Nov 11, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2025
@rustbot

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added the has-merge-commits PR has merge commits, merge with caution. label Nov 11, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 13, 2026

☔ The latest upstream changes (presumably #150844) made this pull request unmergeable. Please resolve the merge conflicts.

@TomtheCoder2 TomtheCoder2 force-pushed the unconstrained-parameter-fix branch from de845c2 to 1f5e308 Compare March 5, 2026 01:42
@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Mar 5, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@TomtheCoder2 TomtheCoder2 requested a review from davidtwco March 8, 2026 04:20
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 8, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@TomtheCoder2 TomtheCoder2 force-pushed the unconstrained-parameter-fix branch from bbce6e5 to 06e17b4 Compare March 9, 2026 00:09
@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 10, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@TomtheCoder2
Fix unconstrained parameter issue
0ade480
@TomtheCoder2
fix tests
a8a7e19
@TomtheCoder2
fix rustdoc ui test
12340a8
@TomtheCoder2
fix tests
69165e1
@TomtheCoder2
fix tests (added the help messages in the code too)
e7d4c8a
@TomtheCoder2
fixed tests (hope the last time)
1065e84
@TomtheCoder2
prepared the search for the generics in the impl and struct definitio…
3d49089 
…ns to determine if it makes sense to suggest adding the extra parameter to the generics of the struct on the impl ... for ...<> line
@TomtheCoder2
first check if the struct Foo has a missing generic parameter
bf798a3
@TomtheCoder2
adapted test outputs
179940d
@TomtheCoder2
fixed tests
9d1025b
@TomtheCoder2
fixed some comments
c735d38
@TomtheCoder2
moved from multi part suggestions, to multiple single suggestions
8200d5c
@TomtheCoder2
fixed the two failing tests
71ecd9b
@TomtheCoder2
more readable comments
5d77bb2
@TomtheCoder2
fixed typo
48c4e3c
@TomtheCoder2
fmt
78b460f
@TomtheCoder2
moved the suggestion code to the error module
d5406c4 
Signed-off-by: janwi_mac <jan.wilhelm77@gmail.com>
@TomtheCoder2
added doc comments for the new functions
2461e5d 
Signed-off-by: janwi_mac <jan.wilhelm77@gmail.com>
@TomtheCoder2
added new test cases for to exercise the new branches added in the
1cdc8cb 
`suggest_to_remove_or_use_generic` function

Signed-off-by: janwi_mac <jan.wilhelm77@gmail.com>
@TomtheCoder2
adapted test outputs to the new behaviour: suggesting adding the
0b83de8 
parameter to the impl struct and the struct definition if used in the
impl body

Signed-off-by: janwi_mac <jan.wilhelm77@gmail.com>
@TomtheCoder2 TomtheCoder2 force-pushed the unconstrained-parameter-fix branch from 1747f90 to 0b83de8 Compare March 11, 2026 03:18
@rustbot
Copy link
Collaborator

rustbot commented Mar 11, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@TomtheCoder2
fixed test
7664723 
Signed-off-by: janwi_mac <jan.wilhelm77@gmail.com>
@TomtheCoder2
Copy link
Author

TomtheCoder2 commented Mar 11, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwco davidtwco davidtwco requested changes

Assignees

@davidtwco davidtwco

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TomtheCoder2 @rustbot @rust-log-analyzer @davidtwco