Dist Enzyme for macOS with unversioned LLVM dylib#151063
Dist Enzyme for macOS with unversioned LLVM dylib#151063sgasho wants to merge 3 commits intorust-lang:mainfrom
Conversation
|
@bors delegate try |
|
Unknown command "delegate". Run |
|
Hmm, not sure about the exact syntax, but delegate itself should have been recognized, maybe not ported to the new bots yet? I'll let Jakub handle it. @bors try jobs=dist-aarch64-apple |
This comment has been minimized.
This comment has been minimized.
Add dist step for enzyme, including aarch64-apple-darwin try-job: dist-aarch64-apple
|
@bors delegate=try |
|
✌️ @sgasho, you can now perform try builds on this pull request! You can now post |
|
☔ The latest upstream changes (presumably #150541) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors try jobs=dist-aarch64-apple |
This comment has been minimized.
This comment has been minimized.
30f87bc to
31d3fde
Compare
|
@bors try jobs=dist-aarch64-apple |
This comment has been minimized.
This comment has been minimized.
Add dist step for enzyme, including aarch64-apple-darwin try-job: dist-aarch64-apple
This comment has been minimized.
This comment has been minimized.
bc7b483 to
98144d4
Compare
|
@bors try jobs=dist-aarch64-apple |
This comment has been minimized.
This comment has been minimized.
Add dist step for enzyme, including aarch64-apple-darwin try-job: dist-aarch64-apple
|
💔 Test for 2c9be7e failed: CI. Failed job:
|
So, for Apple it's not that big of a deal today I guess (though I would still do a vibe check with t-infra), but 9 MiB compressed isn't nothing. So if there are no other big considerations or trade-offs, dynamic linking seems better in that regard. |
…r=Kobzol Enable autodiff in ci for all major os *[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust/pull/152768)* Follow-up attempt to rust-lang#140064 after moving autodiff to dlopen. It covers Linux (x86_64+aarch64), MacOS (aarch64), Windows (mingw-llvm aarch64+x86_64) The extra build time for Enzyme are 180.27s on our slowest runner (aarch64-apple). The follow-up distribution via rustup probably still needs a small fix, see rust-lang#151063 (comment) Placing the downloaded libEnzyme artifact on my local linux under `~/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib` enables my nightly compiler to run autodiff. r? @Kobzol closes: rust-lang#140064 closes: rust-lang#151243 closes: rust-lang#151063
Rollup merge of #152768 - ZuseZ4:autodiff-in-ci-for-all-os, r=Kobzol Enable autodiff in ci for all major os *[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust/pull/152768)* Follow-up attempt to #140064 after moving autodiff to dlopen. It covers Linux (x86_64+aarch64), MacOS (aarch64), Windows (mingw-llvm aarch64+x86_64) The extra build time for Enzyme are 180.27s on our slowest runner (aarch64-apple). The follow-up distribution via rustup probably still needs a small fix, see #151063 (comment) Placing the downloaded libEnzyme artifact on my local linux under `~/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib` enables my nightly compiler to run autodiff. r? @Kobzol closes: #140064 closes: #151243 closes: #151063
b176c34 to
cf6a8fe
Compare
|
@bors try jobs=dist-aarch64-apple |
This comment has been minimized.
This comment has been minimized.
Dist Enzyme for macOS with unversioned LLVM dylib try-job: dist-aarch64-apple
|
💔 Test for d9e7df3 failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
|
@bors try jobs=dist-aarch64-apple |
This comment has been minimized.
This comment has been minimized.
Dist Enzyme for macOS with unversioned LLVM dylib try-job: dist-aarch64-apple
|
💔 Test for aac8c8c failed: CI. Failed job:
|
|
The job Click to see the possible cause of the failure (guessed by this bot) |
View all comments
Follow-up to #152768.