Port diagnostic attributes by mejrs · Pull Request #151558 · rust-lang/rust

mejrs · 2026-01-23T23:46:13Z

Ports all the diagnostic attributes: on_const, on_unimplemented and rustc_on_unimplemented.

I thought about migrating them one by one but that would leave a lot of code duplicated. So this PR looks big but it's mostly a lot of moving code around with slight modifications.

r? @JonathanBrouwer

cc @jdonszelmann feel free to review if you want, not sure which of you wants it.

JonathanBrouwer · 2026-01-23T23:54:41Z

@bors try @rust-timer queue

Port diagnosttic::unimplemented

rust-bors · 2026-01-24T02:12:50Z

☀️ Try build successful (CI)
Build commit: e5e5a65 (e5e5a6588240040eb81cfb52d8b9c3281547ef47, parent: d222ddc4d90743dfc1e53b610be8fc9d95893d2c)

rust-timer · 2026-01-24T02:54:28Z

Finished benchmarking commit (e5e5a65): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -1.7%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.9%	[3.9%, 3.9%]	1
Improvements ✅ (primary)	-1.7%	[-1.7%, -1.7%]	1
Improvements ✅ (secondary)	-4.2%	[-4.2%, -4.2%]	1
All ❌✅ (primary)	-1.7%	[-1.7%, -1.7%]	1

Cycles

Results (secondary -4.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.3%	[-4.9%, -3.0%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 470.684s -> 471.14s (0.10%)
Artifact size: 383.48 MiB -> 383.64 MiB (0.04%)

rustbot · 2026-02-24T09:56:43Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

mejrs · 2026-02-24T12:31:58Z

had to rebase on github.com//pull/152985, unlucky that merged an hour before i guess

@rustbot ready

JonathanBrouwer · 2026-02-24T12:33:27Z

@bors r=jdonszelmann,jonathanbrouwer rollup

rust-bors · 2026-02-24T12:33:30Z

📌 Commit 0b14bd4 has been approved by jdonszelmann,jonathanbrouwer

It is now in the queue for this repository.

…uwer Rollup of 15 pull requests Successful merges: - #152176 (Neon fast path for str::contains) - #152657 (std: move `exit` out of PAL) - #152841 (Streamline `QueryVTableUnerased` into `GetQueryVTable`) - #152845 (Skip `tidy` in PR CI jobs not dedicated to running `tidy`) - #152897 (Add optional json logging) - #153009 (Remove `rustc_feedable_queries` and `define_feedable` macros.) - #151558 (Port diagnostic attributes) - #152492 (mGCA: Enforce WF element types for array valtrees) - #152888 (Fix async drop glue MIR bug) - #152988 (Port `#[register_tool]` to the new attribute system) - #153018 (`unused_must_use` lint improvements) - #153023 (Update books) - #153033 (Clarify how "ensure" queries check whether they can skip execution) - #153043 (fix error on missing value for -C flags) - #153045 (rustc-dev-guide subtree update) Failed merges: - #153032 (Fix attribute parser and kind names.)

@JonathanBrouwer

Rollup merge of #151558 - mejrs:port_on_unimplemented, r=jdonszelmann,jonathanbrouwer Port diagnostic attributes *[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust/pull/151558)* Ports all the diagnostic attributes: on_const, on_unimplemented and rustc_on_unimplemented. I thought about migrating them one by one but that would leave a lot of code duplicated. So this PR looks big but it's mostly a lot of moving code around with slight modifications. r? @JonathanBrouwer cc @jdonszelmann feel free to review if you want, not sure which of you wants it.

…uwer Rollup of 15 pull requests Successful merges: - rust-lang/rust#152176 (Neon fast path for str::contains) - rust-lang/rust#152657 (std: move `exit` out of PAL) - rust-lang/rust#152841 (Streamline `QueryVTableUnerased` into `GetQueryVTable`) - rust-lang/rust#152845 (Skip `tidy` in PR CI jobs not dedicated to running `tidy`) - rust-lang/rust#152897 (Add optional json logging) - rust-lang/rust#153009 (Remove `rustc_feedable_queries` and `define_feedable` macros.) - rust-lang/rust#151558 (Port diagnostic attributes) - rust-lang/rust#152492 (mGCA: Enforce WF element types for array valtrees) - rust-lang/rust#152888 (Fix async drop glue MIR bug) - rust-lang/rust#152988 (Port `#[register_tool]` to the new attribute system) - rust-lang/rust#153018 (`unused_must_use` lint improvements) - rust-lang/rust#153023 (Update books) - rust-lang/rust#153033 (Clarify how "ensure" queries check whether they can skip execution) - rust-lang/rust#153043 (fix error on missing value for -C flags) - rust-lang/rust#153045 (rustc-dev-guide subtree update) Failed merges: - rust-lang/rust#153032 (Fix attribute parser and kind names.)

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 23, 2026