Stop using rustc_layout_scalar_valid_range_* in rustc

[oli-obk]

View all comments

Another step towards #135996

Required some manual impls, but we already do many manual impls for the newtype_index types, so it's not really a new maintenance burden.

[rustbot]

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in coverage instrumentation.

cc @Zalathar

[rustbot]

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 68 candidates
• Random selection from 18 candidates

[davidtwco]

LGTM with CI failures fixed

View changes since this review

[oli-obk]

@bors r=davidtwco

[rust-bors]

📌 Commit 01df8d6 has been approved by davidtwco

It is now in the queue for this repository.

[oli-obk]

oh wait

@bors r-

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: e8d615a (e8d615a27a9044825333881a720535b5c42eb976, parent: 71e00273c0921e1bc850ae8cc4161fbb44cfa848)

[rust-timer]

Finished benchmarking commit (e8d615a): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	2
Regressions ❌ (secondary)	0.4%	[0.3%, 0.5%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.3%, -0.1%]	5
All ❌✅ (primary)	0.2%	[0.2%, 0.2%]	2

Max RSS (memory usage)

Results (primary 2.7%, secondary -3.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.7%, 2.7%]	1
Regressions ❌ (secondary)	4.9%	[4.9%, 4.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-6.2%	[-6.9%, -5.4%]	3
All ❌✅ (primary)	2.7%	[2.7%, 2.7%]	1

Cycles

Results (secondary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 485.967s -> 484.264s (-0.35%)
Artifact size: 397.80 MiB -> 397.80 MiB (0.00%)

[oli-obk]

@bors r=davidtwco

The detailed view of the instruction count regression shows measures time improvements. Those look random, too, so I'm guessing it's just noise

[rust-bors]

📌 Commit 01df8d6 has been approved by davidtwco

It is now in the queue for this repository.

[jhpratt]

Given the large number of rollup=never PRs in the queue and the apparent noise here,

@bors rollup=iffy

[JonathanBrouwer]

@bors try jobs=dist-x86_64-linux-alt

[rust-bors]

💔 Test for 0825e37 failed: CI. Failed job:

• try - dist-x86_64-linux-alt (web logs, enhanced plaintext logs)

[JonathanBrouwer]

@bors r-

[rust-bors]

Commit e62bc63 has been unapproved.

This PR was contained in a rollup (#152810), which was also unapproved.

[oli-obk]

oh no 🙈 I think I need to wait for a bootstrap bump before I can use it in rustc

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[oli-obk]

@bors r=davidtwco

[rust-bors]

📌 Commit ff7e604 has been approved by davidtwco

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.