Skip to content

core: remove FIXME comment in option.rs FromIterator#153418

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
softmoth:patch-1
Mar 13, 2026
Merged

core: remove FIXME comment in option.rs FromIterator#153418
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
softmoth:patch-1

Conversation

@softmoth
Copy link
Contributor

@softmoth softmoth commented Mar 4, 2026 •
edited
Loading

The referenced issue #11084 was closed in 2021, and the related PR #59605 was not merged due to inconclusive results. Similar code (in result.rs, for example) doesn't have this FIXME comment; this is the only reference to issue 11084 (or pull request 59605).

This FIXME was not mentioned in issue #44366.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 4, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 4, 2026

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, joboet, scottmcm

@rustbot

This comment has been minimized.

Sign in to view
@joboet
Copy link
Member

joboet commented Mar 12, 2026

I'd prefer to move the FIXME to try_process – we might be able to get rid of GenericShunt in favour of scan.

@joboet
Copy link
Member

joboet commented Mar 12, 2026

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 12, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@softmoth
core: lift FIXME comment from option.rs to iter::try_process
ea674ec 
This FIXME is relevant not only to Option but other similar cases that
use iter::try_process(). The referenced issue 11084 was closed in 2021,
and the related PR 59605 was not merged due to inconclusive results.
@rustbot
Copy link
Collaborator

rustbot commented Mar 13, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@softmoth
Copy link
Contributor Author

softmoth commented Mar 13, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 13, 2026
@joboet
Copy link
Member

joboet commented Mar 13, 2026

👍
@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 13, 2026

📌 Commit ea674ec has been approved by joboet

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2026
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 13, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Mar 13, 2026
@bors
Auto merge of #153832 - matthiaskrgr:rollup-tOzZz0L, r=matthiaskrgr
1d8897a 
Rollup of 3 pull requests

Successful merges:

 - #153418 (core: remove FIXME comment in option.rs FromIterator)
 - #153569 (Fix grammar in Pin documentation)
 - #153798 (Remove unused `SelectionCandidate::PointerLikeCandidate`)
@rust-bors rust-bors bot merged commit 12d320f into rust-lang:main Mar 13, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joboet joboet

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

3 participants

@softmoth @rustbot @joboet