Open
Conversation
rustbot
added
A-query-system
Contributor
Author
Zoxc
reviewed
Mar 6, 2026
Zoxc
reviewed
Mar 6, 2026
Zoxc
reviewed
Mar 6, 2026
nnethercote
force-pushed
the
complete_inner
branch
2 times, most recently
from
61284b1 to
232409f
Compare
Zoxc
reviewed
Mar 6, 2026
Contributor
|
What is EDIT: Ahh, so it's the |
zetanumbers
reviewed
Mar 6, 2026
petrochenkov
reviewed
Mar 6, 2026
petrochenkov
added
S-waiting-on-author
Contributor
|
Outside of those suggestions this code looks pretty clean. |
nnethercote
force-pushed
the
complete_inner
branch
from
232409f to
1a05470
Compare
Contributor
Author
|
lol, I don't think I've ever had comments from this many people for a small refactoring PR :) Anyway, I think all comments have now been addressed. |
Member
|
I had intended to move the struct definition when I did the rename, but it got lost during a non-trivial rebase, so I’m happy to see it moved in this PR. |
This comment has been minimized.
This comment has been minimized.
`ActiveJobGuard::complete` and `ActiveJobGuard::drop` have very similar code, though non-essential structural differences obscure this a little. This commit factors out the common code into a new method `ActiveJobGuard::complete_inner`. It also inlines and remove `expect_job`, which ends up having a single call site.
nnethercote
force-pushed
the
complete_inner
branch
from
1a05470 to
18ade84
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
I rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few small improvements.
r? @petrochenkov