rustc_codegen_ssa: Define ELF flag value for sparc-unknown-linux-gnu#153537
Open
taiki-e wants to merge 1 commit intorust-lang:mainfrom
Open
rustc_codegen_ssa: Define ELF flag value for sparc-unknown-linux-gnu#153537taiki-e wants to merge 1 commit intorust-lang:mainfrom
taiki-e wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
|
Contributor
|
Looks good to me, but I would prefer a commit message that reflects the actual change, i.e.:
Thanks for fixing this! |
taiki-e
changed the title
Member
Author
|
@glaubitz Thanks for the review. I updated commit message based on your suggestion. |
Contributor
|
Thanks a lot! I appreciate contributions to the SPARC backend very much! There is real SPARC hardware available for testing in the GCC compile farm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, attempting to build this target using Ubuntu/Debian's sparc64-multilib toolchain results in the following link error (full log):
This appears to be caused by the required e_flag being missing and can be fixed by setting
EF_SPARC_32PLUS.Tested using rustc with this patch applied and qemu-user (taiki-e/atomic-maybe-uninit@57d7e7f, log).
Related discussion: #131222 (comment)
r? workingjubilee
cc @glaubitz
@rustbot label +O-SPARC