Skip to content

rustdoc-json: Improve docs for ItemEnum::item_kind#153627

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
aDotInTheVoid:rustdocsdocs
Mar 10, 2026
Merged

rustdoc-json: Improve docs for ItemEnum::item_kind#153627
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
aDotInTheVoid:rustdocsdocs

Conversation

@aDotInTheVoid
Copy link
Member

@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2026

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @Enselic, @obi1kenobi

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 9, 2026
@GuillaumeGomez
Copy link
Member

Thanks! r=me once CI is happy.

@aDotInTheVoid
Copy link
Member Author

@bors r=GuillaumeGomez rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 10, 2026

📌 Commit ca9bd0d has been approved by GuillaumeGomez

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2026
rust-bors bot pushed a commit that referenced this pull request Mar 10, 2026
Rollup of 4 pull requests

Successful merges:

 - #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
 - #153325 (tests/ui/cfg: add annotations for reference rules)
 - #153621 (Remove `TyCtxt::node_span_lint` method)
 - #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 10, 2026

⌛ Testing commit ca9bd0d with merge ee703ce...

Workflow: https://github.com/rust-lang/rust/actions/runs/22896614705

rust-bors bot pushed a commit that referenced this pull request Mar 10, 2026
@JonathanBrouwer
Copy link
Contributor

@bors yield

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 10, 2026

Auto build was cancelled. Cancelled workflows:

The next pull request likely to be tested is #148562.

rust-bors bot pushed a commit that referenced this pull request Mar 10, 2026
Rollup of 4 pull requests

Successful merges:

 - #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
 - #153325 (tests/ui/cfg: add annotations for reference rules)
 - #153621 (Remove `TyCtxt::node_span_lint` method)
 - #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
rust-bors bot pushed a commit that referenced this pull request Mar 10, 2026
Rollup of 4 pull requests

Successful merges:

 - #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
 - #153325 (tests/ui/cfg: add annotations for reference rules)
 - #153621 (Remove `TyCtxt::node_span_lint` method)
 - #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
@rust-bors rust-bors bot merged commit b01e56d into rust-lang:main Mar 10, 2026
11 of 12 checks passed
rust-timer added a commit that referenced this pull request Mar 10, 2026
Rollup merge of #153627 - aDotInTheVoid:rustdocsdocs, r=GuillaumeGomez

rustdoc-json: Improve docs for `ItemEnum::item_kind`

Fixes #153279 (comment)

r? @GuillaumeGomez

CC @LukeMathWalker
@rustbot rustbot added this to the 1.96.0 milestone Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants