Skip to content

find_dep_kind_root tweaks#153690

Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
nnethercote:find_dep_kind_root
Mar 14, 2026
Merged

find_dep_kind_root tweaks#153690
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
nnethercote:find_dep_kind_root

Conversation

@nnethercote
Copy link
Contributor

Two minor changes relating to find_dep_kind_root.

r? @SparrowLii

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 11, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 11, 2026

SparrowLii is not on the review rotation at the moment.
They may take a while to respond.

@rust-log-analyzer

This comment has been minimized.

@rust-bors

This comment has been minimized.

@petrochenkov
Copy link
Contributor

Needs a rebase after the QueryStackDeferred removal.
@rustbot author
r? @petrochenkov

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 13, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot assigned petrochenkov and unassigned SparrowLii Mar 13, 2026
`current_id` is removable.
This requires refactoring `depth_limit_error` to do some extra work
immediately instead of returning a cloned `info`.
@rustbot
Copy link
Collaborator

rustbot commented Mar 13, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@nnethercote
Copy link
Contributor Author

I rebased. Thanks for taking the review.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 13, 2026
@petrochenkov
Copy link
Contributor

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 14, 2026

📌 Commit ddd1a69 has been approved by petrochenkov

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 14, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 14, 2026

☀️ Test successful - CI
Approved by: petrochenkov
Duration: 3h 10m 29s
Pushing fd26499 to main...

@rust-bors rust-bors bot merged commit fd26499 into rust-lang:main Mar 14, 2026
12 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 14, 2026
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 620e36a (parent) -> fd26499 (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard fd2649988fdc91e056ddd316865d33e812f48a0e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 2h 1m -> 1h 31m (-24.1%)
  2. aarch64-apple: 3h 4m -> 2h 33m (-17.1%)
  3. x86_64-gnu-debug: 2h 9m -> 1h 55m (-10.8%)
  4. x86_64-msvc-ext3: 1h 42m -> 1h 53m (+10.5%)
  5. dist-x86_64-illumos: 1h 36m -> 1h 46m (+10.3%)
  6. x86_64-gnu-llvm-21-3: 2h 3m -> 1h 52m (-9.3%)
  7. x86_64-gnu-miri: 1h 29m -> 1h 21m (-8.9%)
  8. i686-gnu-2: 1h 41m -> 1h 32m (-8.8%)
  9. tidy: 2m 41s -> 2m 27s (-8.5%)
  10. i686-gnu-nopt-1: 2h 21m -> 2h 10m (-7.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fd26499): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.0% [-2.6%, -1.1%] 3
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 483.729s -> 481.843s (-0.39%)
Artifact size: 396.86 MiB -> 396.85 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) merged-by-bors This PR was explicitly merged by bors. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants