Refactor query latch

[zetanumbers]

Removed unnecessary mutex for cycle errors.

[rustbot]

r? @madsmtm

rustbot has assigned @madsmtm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler, query-system
• compiler, query-system expanded to 69 candidates
• Random selection from 16 candidates

[zetanumbers]

r? @nnethercote

[Zalathar]

Could you explain what this change is doing, conceptually?

Right now there’s no way to know what’s going on, other than trying to reverse engineer the textual changes.

[nnethercote]

Could you explain what this change is doing, conceptually?

I was going to ask the same thing. A good rule of thumb is "make life as easy as possible for your reviewer". A bit of context and explanation about the PR helps a lot.

[rust-bors]

☔ The latest upstream changes (presumably #153812) made this pull request unmergeable. Please resolve the merge conflicts.

[Zoxc]

Passing the cycle via the latch seems a bit off to me. It does save a lock operation though.

#t-compiler/parallel-rustc > Getting rid of the cycle detection thread would also get rid of the cycle passing if that lands.