Rollup of 5 pull requests#153865
Merged
rust-bors[bot] merged 11 commits intorust-lang:mainfrom Mar 14, 2026
Merged
Conversation
The query's dep kind can be obtained from its vtable instead. This commit also renames the `query_vtable` parameter to `query`, to be more consistent with other functions that take a QueryVTable.
…tie them to cfg(target_abi)
This helps to clarify that the field with type `ChunkSize` is a count of 1s, not a length or size.
…=madsmtm target specs: stricter checks for LLVM ABI values, and correlate that with cfg(target_abi) This tightens the checks for `llvm_abiname`, `llvm_floatabi` and `rustc_abi` in our target specs. Those are the fields that actually control the ccABI. With this commit, we now have an allowlist of value for these fields for all architectures (we previously only had that for some architectures). We also check that `cfg(target_abi)` suitably correlates with the actual ccABI. I based this check on our in-tree targets. For all ccABIs where we had a bunch of "random" values that don't directly correlate to the ccABI (like "uwp"), I also allowed `cfg(target_abi)` to remain empty, and whenever it is allowed to be empty I also allowed arbitrary other values for JSON targets. However, there's still a risk that JSON targets will fail this new check -- the idea is that we'll then get bugreports and can adjust the check as needed. I had to adjust the target specs for non-ARM32 Apple targets as those were all setting `llvm_floatabi`, which to my knowledge makes no sense -- LLVM only actually does anything with that field on ARM32. I also adjusted the target specs for MIPS32 targets: one of them was setting llvm_abiname, and then it seems safer and more consistent to set that for all targets, so I set it to "o32" everywhere which seems to be the default. Cc @workingjubilee
Don't pass a separate `DepKind` to `query_feed` This PR makes two small tweaks to the `query_feed` function, which is called by macro-generated methods on TyCtxtFeed: - Don't pass `DepKind` as a separate argument, because it's already in the QueryVTable - Rename `query_vtable` to `query`, to match other functions that take QueryVTable r? nnethercote (or compiler)
relocate several ui tests Remove `tests/ui/obsolete-in-place` and `tests/ui/operator-recovery`.
…ouxu tests/debuginfo/basic-stepping.rs: Add cdb test Takes us one step closer towards closing rust-lang#33013.
Use named fields in ChunkedBitSet's `Chunk::Mixed` This helps to clarify that the field with type `ChunkSize` is a count of 1s, not a length or size. There should be no change to compiler behaviour.
rustbot
added
O-apple
Member
Author
|
Rollup of everything. @bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing fd26499 (parent) -> 798a011 (this PR) Test differencesShow 20 test diffsStage 1
Stage 2
Additionally, 4 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 798a011ace1c2b5be80767ba1d97a4dff0546f93 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (798a011): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary 2.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 481.843s -> 481.81s (-0.01%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
DepKindtoquery_feed#153811 (Don't pass a separateDepKindtoquery_feed)Chunk::Mixed#153858 (Use named fields in ChunkedBitSet'sChunk::Mixed)r? @ghost
Create a similar rollup