Skip to content

simplify and remove tests/ui/kindck and related tests#154018

Open
cyrgani wants to merge 4 commits intorust-lang:mainfrom
cyrgani:kindck-tests
Open

simplify and remove tests/ui/kindck and related tests#154018
cyrgani wants to merge 4 commits intorust-lang:mainfrom
cyrgani:kindck-tests

Conversation

@cyrgani
Copy link
Contributor

@cyrgani cyrgani commented Mar 17, 2026

kindck does not exist anymore since a long time now. This PR merges and deletes several redundant tests in that directory, reformats the rest and moves it to ui/traits.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 17, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2026

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 15 candidates

@@ -1,49 +0,0 @@
//@ run-pass
Copy link
Contributor Author

@cyrgani cyrgani Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much all comments in this test were wrong nowadays (e.g. they claim that integers could be moved without copying), the functions in the test were never called and the results not checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants