Skip to content

two smaller feature cleanups#154019

Open
cyrgani wants to merge 2 commits intorust-lang:mainfrom
cyrgani:feature-clean
Open

two smaller feature cleanups#154019
cyrgani wants to merge 2 commits intorust-lang:mainfrom
cyrgani:feature-clean

Conversation

@cyrgani
Copy link
Contributor

@cyrgani cyrgani commented Mar 17, 2026

Remove an unneeded feature gate for a private macro and sort the used features correctly by whether they are language or library features.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 17, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2026

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, joboet

@cyrgani cyrgani changed the title Feature clean two smaller feature cleanups Mar 17, 2026
@cyrgani
Copy link
Contributor Author

cyrgani commented Mar 17, 2026

Maybe it would be better to remove the separation between lang and libs features at that point and merge them into a single big // tidy-alphabetical-start section?

@bjorn3
Copy link
Member

bjorn3 commented Mar 18, 2026

According to #87766 the split between language and library features is for the following reason:

For the language features, we should check with the relevant team(s) if it's okay that we're using the feature in the library, and document with which of them we need to be extra careful and what their pitfalls are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants