Conversation
|
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer Some changes occurred in src/tools/compiletest cc @jieyouxu |
|
r? @joboet rustbot has assigned @joboet. Use Why was this reviewer chosen?The reviewer was selected based on:
|
There was a problem hiding this comment.
Please don't modify subtrees like rust-analyzer inside the rust-lang/rust repo unless necessary. Development of rust-analyzer happens at https://github.com/rust-lang/rust-analyzer/
There was a problem hiding this comment.
rebased
For future reference do all subtrees have a josh-sync.toml?
There was a problem hiding this comment.
Most do. The exceptions I believe are compiler/rustc_codegen_cranelift, compiler/rustc_codegen_gcc and src/tools/rustfmt. Those I think are the only ones that still use git-subtree rather than josh for syncing.
There was a problem hiding this comment.
Right, unfortunately there is no reliable method get a list of current subtrees from Git. Perhaps these could be tracked explicitly somewhere?
There was a problem hiding this comment.
No need to, just see if triagebot complains. You can skim https://github.com/rust-lang/rust/blob/main/triagebot.toml if you're wondering.
No description provided.