Remove divergence check from check_expr_array#154031
Open
TaKO8Ki wants to merge 2 commits intorust-lang:mainfrom
Open
Remove divergence check from check_expr_array#154031TaKO8Ki wants to merge 2 commits intorust-lang:mainfrom
TaKO8Ki wants to merge 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
cc @chenyukang (as you added this check originally in #147548) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153695.
check_expr_arraycurrently assumes it should only be entered withself.diverges == Diverges::Maybe, but that assumption does not appear to hold in all valid cases. A never-pattern parameter can seed a function or closure body with inheritedDiverges::Always, and exprs in that body are still typecked.