borrowck/type_check: remove helper left-over from unsized locals#154036
Open
RalfJung wants to merge 1 commit intorust-lang:mainfrom
Open
borrowck/type_check: remove helper left-over from unsized locals#154036RalfJung wants to merge 1 commit intorust-lang:mainfrom
RalfJung wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @nnethercote rustbot has assigned @nnethercote. Use Why was this reviewer chosen?The reviewer was selected based on:
|
RalfJung
commented
Mar 18, 2026
| if !self.unsized_feature_enabled() { | ||
| // When `unsized_fn_params` is enabled, this is checked in `check_call_dest`, | ||
| // and `hir_typeck` still forces all non-argument locals to be sized (i.e., we don't | ||
| // fully re-check what was already checked on HIR). |
Member
Author
There was a problem hiding this comment.
Nullary ops don't exist any more so the comment needed updating.
And from all I can tell, we do not fully re-check non-argument locals to be sized here. Not sure if that is a problem, being sized cannot depend on lifetimes after all. But then I don't know why we re-check any of the sized stuff here.^^
nnethercote
approved these changes
Mar 18, 2026
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 18, 2026
… r=nnethercote borrowck/type_check: remove helper left-over from unsized locals This used to check two features, but ever since rust-lang#141811 it's only one so there's no reason any more to have a helper function here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This used to check two features, but ever since #141811 it's only one so there's no reason any more to have a helper function here.