Skip to content

bootstrap: Allow --blessing changes to editor settings files#154041

Open
jyn514 wants to merge 2 commits intorust-lang:mainfrom
ferrocene:jyn/bless-hashes
Open

bootstrap: Allow --blessing changes to editor settings files#154041
jyn514 wants to merge 2 commits intorust-lang:mainfrom
ferrocene:jyn/bless-hashes

Conversation

@jyn514
Copy link
Member

@jyn514 jyn514 commented Mar 18, 2026

Previously, on any change you would have to first edit all 4 settings files by hand, then run the tests 4 times in a row to discover what the new hashes are. After this change, you still need to edit the files by hand, but you can now run x test --bless -- hash to update the hashes without manually editing them.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 18, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 18, 2026

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: bootstrap
  • bootstrap expanded to 6 candidates
  • Random selection from Mark-Simulacrum, clubby789, jieyouxu

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@jyn514 jyn514 force-pushed the jyn/bless-hashes branch from 4c78a00 to b330bba Compare March 18, 2026 13:16
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. One doc request, but otherwise this is a nice QoL improvement when editing setup editor configs
@rustbot author

View changes since this review

return;
}

if option_env!("INSTA_UPDATE") == Some("always") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: hm, I think this is only currently used for cargo insta path resolution snapshot tests, but recycling it for blessing editor hashes seems... fine.

return;
}

if option_env!("INSTA_UPDATE") == Some("always") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: could we maybe document INSTA_UPDATE=always ==> rebless editor hashes in bootstrap setup in rustc-dev-guide somewhere? Otherwise it's really hard to discover (since INSTA_UPDATE=1 won't work).

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants