bootstrap: Allow --blessing changes to editor settings files#154041
bootstrap: Allow --blessing changes to editor settings files#154041jyn514 wants to merge 2 commits intorust-lang:mainfrom
--blessing changes to editor settings files#154041Conversation
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
ddf0c42 to
4c78a00
Compare
This comment has been minimized.
This comment has been minimized.
4c78a00 to
b330bba
Compare
There was a problem hiding this comment.
Thanks. One doc request, but otherwise this is a nice QoL improvement when editing setup editor configs
@rustbot author
| return; | ||
| } | ||
|
|
||
| if option_env!("INSTA_UPDATE") == Some("always") { |
There was a problem hiding this comment.
Remark: hm, I think this is only currently used for cargo insta path resolution snapshot tests, but recycling it for blessing editor hashes seems... fine.
| return; | ||
| } | ||
|
|
||
| if option_env!("INSTA_UPDATE") == Some("always") { |
There was a problem hiding this comment.
Suggestion: could we maybe document INSTA_UPDATE=always ==> rebless editor hashes in bootstrap setup in rustc-dev-guide somewhere? Otherwise it's really hard to discover (since INSTA_UPDATE=1 won't work).
Previously, on any change you would have to first edit all 4 settings files by hand, then run the tests 4 times in a row to discover what the new hashes are. After this change, you still need to edit the files by hand, but you can now run
x test --bless -- hashto update the hashes without manually editing them.