simd_fmin/fmax: make semantics and name consistent with scalar intrinsics#154043
simd_fmin/fmax: make semantics and name consistent with scalar intrinsics#154043RalfJung wants to merge 1 commit intorust-lang:mainfrom
Conversation
|
Some changes occurred in compiler/rustc_codegen_gcc The Miri subtree was changed cc @rust-lang/miri Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter cc @rust-lang/miri, @oli-obk, @lcnr Some changes occurred to the CTFE machinery Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 Some changes occurred to the platform-builtins intrinsics. Make sure the cc @antoyo, @GuillaumeGomez, @bjorn3, @calebzulawski, @programmerjake
cc @Amanieu, @folkertdev, @sayantn Portable SIMD is developed in its own repository. If possible, consider making this change to rust-lang/portable-simd instead. cc @calebzulawski, @programmerjake Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri |
|
r? @chenyukang rustbot has assigned @chenyukang. Use Why was this reviewer chosen?The reviewer was selected based on:
|
| } | ||
| sym::simd_maximum_number_nsz => { | ||
| crate::num::codegen_float_max(fx, x_lane, y_lane) | ||
| } |
There was a problem hiding this comment.
Looks like the previous PR changed the behavior of both the scalar and SIMD intrinsics in cranelift oops. Well, with this PR that actually matches what we document then. ;)
This is the SIMD version of #153343: change the documented semantics of the SIMD float min/max intrinsics to that of the scalar intrinsics, and also make the name consistent.
In terms of providers of this API:
minimumnuminstead ofminnum, thus giving us the new semantics.In terms of consumers of this API:
Q: Should there be an
fin the intrinsic name to indicate that it is for floats? E.g.,simd_fminimum_number_nsz?Also see #153395.