Don't emit rustdoc missing_doc_code_examples lint on impl items#154048
Open
GuillaumeGomez wants to merge 2 commits intorust-lang:mainfrom
Open
Don't emit rustdoc missing_doc_code_examples lint on impl items#154048GuillaumeGomez wants to merge 2 commits intorust-lang:mainfrom
missing_doc_code_examples lint on impl items#154048GuillaumeGomez wants to merge 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lolbinarycat realized in this comment that we weren't testing some cases for the
missing_doc_code_exampleslint. Turns out that it was not handling this case well. =DSo in short:
missing_doc_code_exampleslint should not be emitted on impl items and this PR fixes that.r? @lolbinarycat