Updated RELEASES.md for 1.35.0#60546
Closed
XAMPPRocky wants to merge 6 commits intorust-lang:masterfrom
Closed
Conversation
Centril
suggested changes
May 4, 2019
Co-Authored-By: XAMPPRocky <4464295+XAMPPRocky@users.noreply.github.com>
Centril
reviewed
May 4, 2019
jonas-schievink
suggested changes
May 4, 2019
taiki-e
reviewed
May 4, 2019
Member
|
@rustbot modify labels: beta-accepted |
sfackler
reviewed
May 4, 2019
Co-Authored-By: XAMPPRocky <4464295+XAMPPRocky@users.noreply.github.com>
Co-Authored-By: XAMPPRocky <4464295+XAMPPRocky@users.noreply.github.com>
Co-Authored-By: XAMPPRocky <4464295+XAMPPRocky@users.noreply.github.com>
Member
|
This is looking good to me; let's aim to get it landed this week so we're ready for release next week. |
BatmanAoD
approved these changes
May 14, 2019
Collaborator
|
☔ The latest upstream changes (presumably #60787) made this pull request unmergeable. Please resolve the merge conflicts. |
emilyalbini
requested changes
May 14, 2019
Member
emilyalbini
left a comment
There was a problem hiding this comment.
Can you rebase on master and add the CVE number to the 1.34.2 release?
Contributor
|
Closing in favor of #60837 (since I can't push to this fork) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered
r? @Mark-Simulacrum
cc @rust-lang/release @steveklabnik