Skip to content

Set up CI for aarch64-apple-darwin#75991

Merged
bors merged 2 commits intorust-lang:masterfrom
shepmaster:silicon-ci
Oct 12, 2020
Merged

Set up CI for aarch64-apple-darwin#75991
bors merged 2 commits intorust-lang:masterfrom
shepmaster:silicon-ci

Conversation

@shepmaster
Copy link
Member

No description provided.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2020
@shepmaster

This comment has been minimized.

@bors

This comment has been minimized.

@shepmaster
Copy link
Member Author

r? @pietroalbini

@bors

This comment has been minimized.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2020
@shepmaster

This comment has been minimized.

@bors

This comment has been minimized.

@bors

This comment has been minimized.

@shepmaster

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Aug 27, 2020

⌛ Trying commit 927ee0620ed011e284a915d358d160315217ec1f with merge d8b81c884750a4b6d7fb3ee3f8a1f646ad24c982...

@bors

This comment has been minimized.

@shepmaster

This comment has been minimized.

@bors

This comment has been minimized.

@bors

This comment has been minimized.

@shepmaster

This comment has been minimized.

@bors

This comment has been minimized.

@bors

This comment has been minimized.

@shepmaster

This comment has been minimized.

@bors

This comment has been minimized.

@shepmaster
Copy link
Member Author

Changes look good by the way!

Or they would if I knew how booleans worked 🤦‍♂️

@shepmaster

This comment has been minimized.

@bors

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Sep 22, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 462ec6baef52edea591eab1a070ed4e18b80d094 (462ec6baef52edea591eab1a070ed4e18b80d094)

@shepmaster
Copy link
Member Author

Ok, with that try build I can do something like

% rustup-toolchain-install-master --force 462ec6baef52edea591eab1a070ed4e18b80d094 --targets aarch64-apple-darwin

% SDKROOT=$(xcrun -sdk macosx11.0 --show-sdk-path) MACOSX_DEPLOYMENT_TARGET=$(xcrun -sdk macosx11.0 --show-sdk-platform-version) cargo +462ec6baef52edea591eab1a070ed4e18b80d094 build --target=aarch64-apple-darwin

And cross-compile easily. Now we just need to wait for Mark-Simulacrum's PRs to get merged and I'll rebase and move the changes to their own regular builders.

@shepmaster
Copy link
Member Author

wait for Mark-Simulacrum's PRs to get merged

This has happened.

I'll rebase and move the changes to their own regular builders.

As has this.

@emilyalbini
Copy link
Member

This PR is promoting the aarch64-apple-darwin target from Tier 3 to a Tier 2 development platform:

  • For infrastructure approval I'd say it doesn't need consensus from the whole team, as we definitely have capacity for a standard sized builder (we don't have XL macOS builders).
  • For compiler team approval, I'm nominating this PR.

@rustbot modify labels: T-compiler I-nominated

@emilyalbini
Copy link
Member

This PR also needs to update src/doc/rustc/src/platform-support.md.

@wesleywiser
Copy link
Member

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Sep 24, 2020

Team member @wesleywiser has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@bors

This comment has been minimized.

@bors

This comment has been minimized.

@rfcbot
Copy link

rfcbot commented Oct 1, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@emilyalbini
Copy link
Member

r=me once FCP ends.

@rfcbot
Copy link

rfcbot commented Oct 11, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@shepmaster
Copy link
Member Author

@bors r=@pietroalbini

@bors
Copy link
Collaborator

bors commented Oct 11, 2020

📌 Commit 2fe271e has been approved by pietroalbini

@bors
Copy link
Collaborator

bors commented Oct 11, 2020

⌛ Testing commit 2fe271e with merge 576e227...

@bors
Copy link
Collaborator

bors commented Oct 12, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: pietroalbini
Pushing 576e227 to master...

@glandium
Copy link
Contributor

What's missing to have the rust-std artifacts available to rustup target add? (it's currently saying the toolchain doesn't contain component 'rust-std' for target 'aarch64-apple-darwin' on the nightly off 8dae8cd which is after this was merged)

@shepmaster
Copy link
Member Author

#77895

As for most everything else for this project, the details have been discussed on Zulip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. merged-by-bors This PR was explicitly merged by bors. O-macos Operating system: macOS S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.