Fix ICE regarding infinite recursive type inference ( Issue -> #92470 )

[ghost]

Fixes #92470

[rust-highfive]

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

[ChrisDenton]

You seem to have accidentally a binary file in your commit?

[ghost]

Oh whoops! Was testing out the new build and might've added it, removing. 😅

[LoganDark]

I think you should force push to properly remove the binary from history

[ghost]

I think you should force push to properly remove the binary from history

I will squash the PR when it's ready anyways so it's not an issue.

[davidtwco]

r? @jackh726

You should squash before this is reviewed so that the reviewer can approve immediately rather than waiting for the squash to happen :)

[ghost]

It is currently drafted as I'm figuring out how to fix the tests. I will remember to squash though.

@rustbot author

[rust-log-analyzer]

The job x86_64-gnu-llvm-12 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- [ui] src/test/ui/associated-types/hr-associated-type-bound-2.rs stdout ----

error: /checkout/src/test/ui/associated-types/hr-associated-type-bound-2.rs:11: unexpected error: '11:1: 16:2: overflow evaluating the requirement `<u32 as X<'b>>::U` [E0275]'

error: /checkout/src/test/ui/associated-types/hr-associated-type-bound-2.rs:11: expected message not found: overflow evaluating the requirement `for<'b> u32: X<'b>`
error: 1 unexpected errors found, 1 expected errors not found
status: exit status: 1
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/associated-types/hr-associated-type-bound-2.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-types/hr-associated-type-bound-2" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-types/hr-associated-type-bound-2/auxiliary"
    Error {
        line_num: 11,
        kind: Some(
            Error,
            Error,
        ),
        msg: "11:1: 16:2: overflow evaluating the requirement `<u32 as X<'b>>::U` [E0275]",
Some tests failed in compiletest suite=ui mode=ui host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu
]

not found errors (from test file): [
not found errors (from test file): [
    Error {
        line_num: 11,
        kind: None,
        msg: "overflow evaluating the requirement `for<'b> u32: X<'b>`",
]

thread '[ui] src/test/ui/associated-types/hr-associated-type-bound-2.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:1392:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- [ui] src/test/ui/associated-types/project-recursion-limit-non-fatal.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/associated-types/project-recursion-limit-non-fatal.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-types/project-recursion-limit-non-fatal" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-types/project-recursion-limit-non-fatal/auxiliary"
stdout: none
--- stderr -------------------------------
error[E0275]: overflow evaluating the requirement `<Self as FilterDsl<_>>::Output`
   |
   = help: consider increasing the recursion limit by adding a `#![recursion_limit = "256"]` attribute to your crate (`project_recursion_limit_non_fatal`)
note: required because of the requirements on the impl of `HandleDelete` for `Self`
   |
   |
LL | impl<T> HandleDelete for T

error: aborting due to previous error

For more information about this error, try `rustc --explain E0275`.

[bors]

☔ The latest upstream changes (presumably #91743) made this pull request unmergeable. Please resolve the merge conflicts.

[ghost]

cc @matthewjasper Any idea? Ignore the merge conflict I'll fix it later 🙃

[jackh726]

This is a really hard issue to fix. I've done some experimenting around this before. Don't remember exactly what I tried, but wasn't successful. (There is a whole host of issues, including some under GATs, that stem from this.)