Conversation
…d non-relevant results
nnethercote
approved these changes
Feb 20, 2023
rylev
approved these changes
Feb 20, 2023
Member
rylev
left a comment
rylev
left a comment
There was a problem hiding this comment.
The CI failure has nothing to do with this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the text on the compare page to "No relevant results" when there are non-relevant results filtered out. In theory, we could also generalize to something like "No results (some results are filtered)", but that message would apply everytime, because there are always at least some results for each filter configuration. And since "Show non relevant" is the only filter checkbox that is turned off by default, I think that it makes sense to specialize for it.
Suggested here.