DRAFT! Parse Intent from getIntent() and provide extra getters#4
Draft
DRAFT! Parse Intent from getIntent() and provide extra getters#4
Intent from getIntent() and provide extra getters#4Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #9
Works towards rust-mobile/ndk#275 / rust-mobile/ndk#380, but doesn't yet fully implement the
onNewIntent()callback +setIntent()yet to follow up on new intents delivered to an already running app.Quick draft to see if I could use this crate. While there's exactly zero overlap in the current implementation (this crate only provided setters, whereas I only needed getters), I still think this is the right place to implement (continue implementing...) a JNI-based
Intentwrapper. No other Rust crate exists for this purpose yet while it's still very useful to have in Rust.This renames
IntenttoIntentBuilder(because of storing a "builder-pattern"Resultinside) andInnerto a publicizedIntentwhere a few new getters are implemented. A freewith_current_intent()function is added to provide a view of an'envscopedIntentbased onActivity.getIntent()onndk_context::android_context()(I know, broken design).TODO
.unwrap()with proper result wrappers.Intentstruct where they return normalResults, which can then be captured in theIntentBuilderinstead.