Open
Conversation
Author
|
I'll edit the CHANGELOG and update the PR. |
big-endian: - added endian switch to SeccompCondition::get_data_offsets everything else is endianness independent. - fixed tests to have endianness specific data offsets Signed-off-by: Eddy (Eduard) Stefes <eddy@linux.ibm.com>
s390: - add s390x to generate_syscall_tables and the generates code - add flags and switches for s390x to the backend test: - there is no guarantee that errno is 0 at main entry or thread entry in fact on s390x its 2 ENOENT as rust startup code will try to getauxval(AT_MINSIGSTKSZ) that is not defined. Also getpid WILL NOT reset errno to 0 if it suceeded. Therefore add errno crate and set errno at start of the test to 0. Signed-off-by: Eddy (Eduard) Stefes <eddy@linux.ibm.com>
Signed-off-by: Eddy (Eduard) Stefes <eddy@linux.ibm.com>
Signed-off-by: Eddy (Eduard) Stefes <eddy@linux.ibm.com>
Author
|
Ok. I think all the tests are actually not my fault. this is ready for review. |
theotherjimmy
approved these changes
Mar 12, 2026
theotherjimmy
left a comment
theotherjimmy
left a comment
There was a problem hiding this comment.
Looks good. I appreciate explaining the clearing of errno in one of the commit messages.
Signed-off-by: Eddy (Eduard) Stefes <eddy@linux.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
added big endian support and as first big-endian platform s390x.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.