feat: allow running rdev in a thread#5
Open
Pranav2612000 wants to merge 1 commit intorustdesk-org:masterfrom
Open
feat: allow running rdev in a thread#5Pranav2612000 wants to merge 1 commit intorustdesk-org:masterfrom
Pranav2612000 wants to merge 1 commit intorustdesk-org:masterfrom
Conversation
|
But using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
rdevcrate only works if run on the main thread.Why do we need this change?
listenloop runs usingCFRunLoopGetMainwhich returns the loop of the main thread. This causes problems ifrdevlisten is called in a non-main thread.CFRunLoopGetMainwithCFRunLoopGetCurrentwhich returns the loop of the current thread. This seems to fix the issue. This is also the way its done in the originalrdevcrate LINKGotcha's
CFRunLoopGetCurrentvsCFRunLoopGetMainwhich fixes the issue.