clean up the callback in exit_grab() for macos#6
Open
xosxos wants to merge 1 commit intorustdesk-org:masterfrom
Open
clean up the callback in exit_grab() for macos#6xosxos wants to merge 1 commit intorustdesk-org:masterfrom
exit_grab() for macos#6xosxos wants to merge 1 commit intorustdesk-org:masterfrom
Conversation
exit_grab() for macosexit_grab() for macos
Collaborator
|
Does this fix any bug in RustDesk? |
Author
|
Well, I ran into the following issue: let (tx, rx) = channel();
let tx = Arc::new(tx);
let callback = move |event: Event| -> Option<Event> {
if something {
tx.send(send_an_item);
exit_grab();
}
};
// Blocking
let _ = grab(callback);
drop(tx);
// Cannot receive items, because a reference to `tx` exists inside the boxed callback function
let receive_items = rx.iter().collect();I suppose the question is: should the callback function live on the heap for the duration of the entire program regardless of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise the variables moved into it will never be dropped, and for example, channels inside the callback will not receive.