fix(cri): iterate SET contents in iter_raw_values(), not SET TLV#238
Open
sumleo wants to merge 1 commit intorusticata:masterfrom
Open
fix(cri): iterate SET contents in iter_raw_values(), not SET TLV#238sumleo wants to merge 1 commit intorusticata:masterfrom
sumleo wants to merge 1 commit intorusticata:masterfrom
Conversation
cpu
reviewed
Feb 22, 2026
Collaborator
cpu
left a comment
cpu
left a comment
There was a problem hiding this comment.
I think this fix is another candidate where test coverage would be helpful.
| // to iterate over the individual values inside the SET | ||
| let content = match <Set>::parse_der_as_input(self.value.clone()) { | ||
| Ok((_, (_, content))) => content, | ||
| Err(_) => Input::default(), |
Collaborator
There was a problem hiding this comment.
This seems reasonable for this context, but might be worth mentioning in the rustdoc.
sumleo
force-pushed
the
fix/cri-iter-raw-values
branch
from
6417207 to
50ceefc
Compare
cpu
approved these changes
Mar 9, 2026
Previously iter_raw_values() iterated over the full SET TLV, yielding the SET itself as a single item. Now it parses past the SET header and iterates over the individual values inside the SET. Updated rustdoc to document that the method returns raw DER content of each value within the SET. Added tag assertions in tests to verify that returned items are the inner values (e.g. UTF8String, SEQUENCE) rather than the SET envelope.
sumleo
force-pushed
the
fix/cri-iter-raw-values
branch
from
50ceefc to
254fa3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X509CriAttribute::iter_raw_values()was iterating overself.valuewhich contains the full SET TLV (tag + length + content)AttributeValueentries inside itTest plan
cargo test --all-features