Skip to content

Add support for multiple values of the same name type#394

Open
djc wants to merge 2 commits intomainfrom
multi-names
Open

Add support for multiple values of the same name type#394
djc wants to merge 2 commits intomainfrom
multi-names

Conversation

@djc
Copy link
Member

@djc djc commented Nov 17, 2025

Fixes #81. This is a semver-incompatible change, so will need a version bump.

@djc djc requested a review from cpu November 17, 2025 12:43
@djc
Copy link
Member Author

djc commented Nov 25, 2025

@cpu want to take a look?

@cpu
Copy link
Member

cpu commented Nov 25, 2025

@cpu want to take a look?

Yes, thanks for the ping. I will look in the next day or so.

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this seems OK relative to the existing API, but should have test coverage. Probably at minimum that when we generate a cert with a multi-value DN that we can round trip it through x509-parser. Maybe also some consideration for CSRs?

This is a semver-incompatible change, so will need a version bump.

I would be in favor of holding the release until there's more semver-incompatible work to justify the churn. It doesn't seem particularly urgent IMO.

@djc djc added the next-major-release breaking changes put off until next major release label Jan 27, 2026
@cpu
Copy link
Member

cpu commented Mar 13, 2026

I would be in favor of holding the release until there's more semver-incompatible work to justify the churn.

@djc thoughts on this point? I think there are a couple not-yet-merged PRs that might tip the scales since this one.

@djc
Copy link
Member Author

djc commented Mar 13, 2026

I would be in favor of holding the release until there's more semver-incompatible work to justify the churn.

@djc thoughts on this point? I think there are a couple not-yet-merged PRs that might tip the scales since this one.

Yes, I think there's basically enough here to warrant a 0.15. But, I think we'd want to wait for #414?

@djc djc mentioned this pull request Mar 13, 2026
@djc
Copy link
Member Author

djc commented Mar 13, 2026

(Wrote up the sketch of a plan in #418.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

next-major-release breaking changes put off until next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support multiple DnValue per key in DistinguishedName

4 participants