Add support for multiple values of the same name type#394
Conversation
|
@cpu want to take a look? |
Yes, thanks for the ping. I will look in the next day or so. |
cpu
left a comment
There was a problem hiding this comment.
I think this seems OK relative to the existing API, but should have test coverage. Probably at minimum that when we generate a cert with a multi-value DN that we can round trip it through x509-parser. Maybe also some consideration for CSRs?
This is a semver-incompatible change, so will need a version bump.
I would be in favor of holding the release until there's more semver-incompatible work to justify the churn. It doesn't seem particularly urgent IMO.
@djc thoughts on this point? I think there are a couple not-yet-merged PRs that might tip the scales since this one. |
Yes, I think there's basically enough here to warrant a 0.15. But, I think we'd want to wait for #414? |
|
(Wrote up the sketch of a plan in #418.) |
Fixes #81. This is a semver-incompatible change, so will need a version bump.