Skip to content

chore(docsrs): make docs.rs build work #222

Merged
cpu merged 1 commit intorustls:mainfrom
joshuachp:push-mmolzzuutrkr
Feb 23, 2026
Merged

chore(docsrs): make docs.rs build work #222
cpu merged 1 commit intorustls:mainfrom
joshuachp:push-mmolzzuutrkr

Conversation

@joshuachp
Copy link
Contributor

The nightly feature has been removed in rust 1.92, see docs.rs build failure https://docs.rs/crate/rustls-native-certs/latest/builds/2773223 and rust PR rust-lang/rust#138907.

@djc
Copy link
Member

djc commented Jan 14, 2026

Thanks -- would you mind also renaming it? See the below PR for reference:

@joshuachp joshuachp changed the title chore(docsrs): make docs.rs build work Privatise docsrs cfg flag; fix nightly Jan 14, 2026
@joshuachp joshuachp changed the title Privatise docsrs cfg flag; fix nightly chore(docsrs): make docs.rs build work Jan 14, 2026
@joshuachp
Copy link
Contributor Author

Sure, I can rename the config flag to rustls_docsrs

@joshuachp
Copy link
Contributor Author

@djc I've changed it into rustls_native_certs_docsrs, let me know what you think

@djc djc added this pull request to the merge queue Jan 14, 2026
@djc djc removed this pull request from the merge queue due to a manual request Jan 14, 2026
@djc
Copy link
Member

djc commented Jan 14, 2026

Please squash your commits.

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI seems like it got stuck, but the diff looks good to me. Perhaps rebasing on main & pushing would get CI going again?

The nightly feature has been removed in rust 1.92, see docs.rs build
failure https://docs.rs/crate/rustls-native-certs/latest/builds/2773223
and rust PR rust-lang/rust#138907.

Also, renamed the cfg into `rustls_native_certs_docsrs`. See
rustls/rustls#2682 for more info.
@joshuachp
Copy link
Contributor Author

rebased

@cpu cpu enabled auto-merge February 23, 2026 14:33
@cpu cpu added this pull request to the merge queue Feb 23, 2026
Merged via the queue into rustls:main with commit 6bfe506 Feb 23, 2026
14 checks passed
@joshuachp joshuachp deleted the push-mmolzzuutrkr branch February 23, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants