Skip to content

fix rust 1.94 ambiguous panic macro warnings#449

Merged
cpu merged 1 commit intorustls:mainfrom
cpu:ci/cpu-rust-1.94-clippy-fix
Mar 11, 2026
Merged

fix rust 1.94 ambiguous panic macro warnings#449
cpu merged 1 commit intorustls:mainfrom
cpu:ci/cpu-rust-1.94-clippy-fix

Conversation

@cpu
Copy link
Member

@cpu cpu commented Mar 11, 2026

Fixes findings that have been breaking CI on main since Rust 1.94 released of the form:

error: `panic` is ambiguous
   --> src/./alg_tests.rs:699:26
    |
699 |             unhandled => panic!("extend der2text for tag 0x{unhandled:x?}"),
    |                          ^^^^^ ambiguous name
    |
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
    = note: for more information, see issue #147319 <https://github.com/rust-lang/rust/issues/147319>
    = note: ambiguous because of a conflict between a name from a glob import and an outer scope during import or macro resolution

```
error: `panic` is ambiguous
   --> src/./alg_tests.rs:699:26
    |
699 |             unhandled => panic!("extend der2text for tag 0x{unhandled:x?}"),
    |                          ^^^^^ ambiguous name
    |
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
    = note: for more information, see issue #147319 <rust-lang/rust#147319>
    = note: ambiguous because of a conflict between a name from a glob import and an outer scope during import or macro resolution
```
@cpu cpu self-assigned this Mar 11, 2026
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.72%. Comparing base (e459078) to head (a78e859).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #449   +/-   ##
=======================================
  Coverage   96.72%   96.72%           
=======================================
  Files          20       20           
  Lines        3903     3903           
=======================================
  Hits         3775     3775           
  Misses        128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cpu cpu added this pull request to the merge queue Mar 11, 2026
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe get rid of the prelude wildcard imports anyway?

Merged via the queue into rustls:main with commit 25dc5ee Mar 11, 2026
22 checks passed
@cpu cpu deleted the ci/cpu-rust-1.94-clippy-fix branch March 11, 2026 18:35
@cpu cpu mentioned this pull request Mar 11, 2026
@cpu
Copy link
Member Author

cpu commented Mar 11, 2026

Maybe get rid of the prelude wildcard imports anyway?

Sure, that seems tidier: #450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants