fix rust 1.94 ambiguous panic macro warnings#449
Merged
cpu merged 1 commit intorustls:mainfrom Mar 11, 2026
Merged
Conversation
```
error: `panic` is ambiguous
--> src/./alg_tests.rs:699:26
|
699 | unhandled => panic!("extend der2text for tag 0x{unhandled:x?}"),
| ^^^^^ ambiguous name
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #147319 <rust-lang/rust#147319>
= note: ambiguous because of a conflict between a name from a glob import and an outer scope during import or macro resolution
```
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
=======================================
Coverage 96.72% 96.72%
=======================================
Files 20 20
Lines 3903 3903
=======================================
Hits 3775 3775
Misses 128 128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ctz
approved these changes
Mar 11, 2026
djc
reviewed
Mar 11, 2026
Member
djc
left a comment
There was a problem hiding this comment.
Maybe get rid of the prelude wildcard imports anyway?
djc
approved these changes
Mar 11, 2026
Member
Author
Sure, that seems tidier: #450 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes findings that have been breaking CI on main since Rust 1.94 released of the form: