fix: WasmMinCut Node.js panic from std::time (fixes #267)#268
Open
fix: WasmMinCut Node.js panic from std::time (fixes #267)#268
Conversation
The WASM build was panicking in Node.js because std::time::Instant is not supported on wasm32-unknown-unknown target. This fix: - Adds time_compat module with PortableInstant/PortableTimestamp - Uses monotonic counter in WASM mode (sufficient for ordering/stats) - Uses std::time::Instant on native platforms (accurate timing) - Updates algorithm, canonical, certificate, optimization, subpolynomial modules The fix uses conditional compilation via the existing `wasm` feature flag. Closes #267 Co-Authored-By: claude-flow <ruv@ruv.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
time_compatmodule)wasmfeature is enabledChanges
crates/ruvector-mincut/src/time_compat.rs- PortableInstant/PortableTimestampTest plan
cargo check --target wasm32-unknown-unknown)🤖 Generated with claude-flow