This repository was archived by the owner on Dec 12, 2021. It is now read-only.
changed to use button_to_add instead of link_to_add to make it more sema...#289
Open
leckylao wants to merge 4 commits intoryanb:masterfrom
Open
changed to use button_to_add instead of link_to_add to make it more sema...#289leckylao wants to merge 4 commits intoryanb:masterfrom
leckylao wants to merge 4 commits intoryanb:masterfrom
Conversation
Author
|
It works on Rails 4 and tests all passed now |
Contributor
|
👍 |
1 similar comment
|
+1 |
…n_to_remove with using disabled instead of :_destroy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By reading the article by Heydon http://coding.smashingmagazine.com/2013/08/20/semantic-css-with-intelligent-selectors/. And using the https://github.com/Heydon/REVENGE.CSS.
We would see the warning message for link_to_remove is something like: "Do you mean for this to be a link or a ? It does not link to anything!"
And warning message for link_to_add is something like "If you are going to make it look like a button, make it a button, dammit!"
Therefore, I decided to make a PR for this. Using button instead of link to make it more semantic.