Open
Conversation
Needed change for missing Id tags for input fields.For better accessibility for design customization of Comment Form.
Author
|
@ryancramerdesign Using this now in my own project as it solved the problem for me of adding classes to element by using ID rather than name or tagname. Plus using ID differentiates it from other possible elements which may carry the same name or tagname as the comment form enabling better isolation of field elements and respective class addition from JS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed change for missing Id tags for input fields.For better accessibility for design customization of Comment Form.