Conversation
Author
|
@ryanries thoughts on getting this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Happy Thanksgiving! I wanted to address #22 so I could pause V Rising 😈
I have written C++ but never C, so I would pay special attention to my memory allocation.
As far as the Spectre memory vulnerability warnings go, I tried to address them but the code got pretty ugly and I figured since there isn't any sensitive data inside this process that can be leaked, it's not worth the cost.
While I was in here learning the code base, I factored out a few functions so I could follow it better too.