Open
Conversation
This can happen when rotate_lines > nrow(log_df) Signed-off-by: Peter Solymos <psolymos@gmail.com>
Signed-off-by: Peter Solymos <psolymos@gmail.com>
Signed-off-by: Peter Solymos <psolymos@gmail.com>
Signed-off-by: Peter Solymos <psolymos@gmail.com>
Signed-off-by: Peter Solymos <psolymos@gmail.com>
ryapric
reviewed
Apr 12, 2022
R/configurations.R
Outdated
Owner
There was a problem hiding this comment.
I think given the naming convention of the function itself (set_rotate_lines() vs. e.g. set_rotation_on()), this should default to NULL instead of an integer, since it expects an integer. Might need a check in rotate_logs() as well if NULL is passed in, so it doesn't crash.
Owner
|
Thank you, looks pretty good! Could you also add some tests to confirm functionality? |
Author
|
@ryapric I addressed the comments. Let me know what you think. |
ryapric
reviewed
Apr 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #20 and fixes an issue when
nrow(log_df) - rotate_lines + 1leads to negative row index.