meta-evaluate now runs to a fixed point#32
Open
tycho-bear wants to merge 4 commits intos-expressionists:mainfrom
Open
meta-evaluate now runs to a fixed point#32tycho-bear wants to merge 4 commits intos-expressionists:mainfrom
tycho-bear wants to merge 4 commits intos-expressionists:mainfrom
Conversation
…a constant number of passes.
Collaborator
|
Meta-evaluate does more than derive types, so this would completely break other stuff like if-simplification. |
Collaborator
|
An actual implementation would keep track of all changes to the flow graph (expensive). So a proper implementation would add a flag to all BIR structures and carefully define a protocol for flagging when things change to prevent infinite regress. |
Member
|
Why do we need a flag on each structure, as opposed to just flipping a boolean variable during meta-evaluate to indicate we made a change? Is it just so that we only reprocess the stuff that has actually changed rather than the whole graph? |
Collaborator
|
Yes. |
added 3 commits
July 15, 2024 18:13
…ype derivation. Additionally, updated its meta-evaluate-iblock function to only process flagged instructions.
…hat arise from evaluating meta-evaluate-instruction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated meta-evaluate.lisp to run to a fixed point instead of making a constant number of passes.