chore(v11): verify L2/L3 dead code removal complete#210
Merged
satwareAG-ironMike merged 2 commits intosatware-mainfrom Apr 9, 2026
Merged
chore(v11): verify L2/L3 dead code removal complete#210satwareAG-ironMike merged 2 commits intosatware-mainfrom
satwareAG-ironMike merged 2 commits intosatware-mainfrom
Conversation
- config.w32: 'PHP 8.1+' -> 'PHP 8.2+' (stale comment) - spec-v11-modernization.md: mark L2 and L3 as done - L2: gds32_ms was already removed, only fbclient_ms.lib used - L3: no dead FB_API_VER < 30 branches exist, only #error guards - NEXT_STEPS.md: sync completed specs and v11 status Closes #178, closes #179
Comprehensive plan for M2 (typed arginfo), M12 (call_user_function elimination), and M3 (resource-to-object migration). Key findings from investigation: - 80 of 82 arginfo declarations need typed return macros - 6 call_user_function sites to replace with direct C calls - 7 resource types to migrate across ~40+ consumer sites - 21 test files need is_resource -> instanceof updates - 277 total .phpt tests to validate Phased approach: M2 (non-breaking) -> M12 (internal) -> M3 (breaking)
satwareAG-ironMike
force-pushed
the
feat/v11-dead-code-removal
branch
from
b158bc8 to
feb25dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verifies that the two dead code removal items from the v11.0 modernization spec are already complete:
L2: Remove legacy gds32_ms fallback from config.w32 (#179)
config.w32already usesfbclient_ms.libonly - nogds32_msreference existsPHP 8.1+->PHP 8.2+L3: Remove dead FB_API_VER < 30 code paths (#178)
FB_API_VER < 30references remain, both are#errorcompile-time safety guardsFB_API_VERguards are>= 40or>= 50(feature gates for FB 4.0/5.0)Also included
spec-v11-modernization.md: L2 and L3 marked doneNEXT_STEPS.md: sync v11 status and completed v10.x specsCloses #178, closes #179