Open
Conversation
Author
|
The builds are failing because they are using the published version of that rbenv gem, I wasn't sure how to have travis use my branch of it (without that resulting change ending up as part of this pull) so I haven't updated the tests yet. |
Collaborator
rbenv:
repo: "git://github.com/alup/puppet-rbenv.git"
ref: "6628a24"point it to your repo/branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposing a better fix to the install rc file creation from #114, this is dependent on an upstream fix from rbenv (alup/puppet-rbenv#121) that adds support for multiple RC files.
Commit c816c60 includes a change to specify the rcfile in the install block, this works without upstream fix.
Commit d9adfbc includes a change that requires the upstream rbenv fix.
Without this fix I ran into an error on the first puppet run that it couldn't find bundler, this might have been a dependency issue but with this fix it works on the first puppet run.