Merged
Conversation
added 17 commits
September 18, 2025 11:27
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a live service feature that enables real-time telemetry streaming from devices through WebSocket connections. The implementation includes a factory pattern for creating device connections, async message handling, and a decorator-based subscription system for raw telemetry data.
- Factory pattern implementation for creating devices and WebSocket connections
- Device class with decorator-based subscription to raw telemetry data
- WebSocket connection management with async message handling
- Comprehensive test suite covering connection factories, devices, and WebSocket functionality
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/scadable/live_query/__init__.py |
Exports main classes for the live query module |
src/scadable/live_query/live_telemetry.py |
Implements DeviceFactory and Device classes for telemetry handling |
src/scadable/live_query/connection_type.py |
Defines connection abstractions and WebSocket implementation |
src/scadable/__init__.py |
Updates main module to include live_query |
tests/test_live_query.py |
Tests for device factory and connection functionality |
tests/test_connection_type.py |
Tests for WebSocket connection implementation |
pyproject.toml |
Adds websockets and pytest-asyncio dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
added 10 commits
September 20, 2025 17:24
…handlers being added and some not, now it just throws runtime error and no handlers are added
Member
Author
Contributor
|
Would fix the naming but that can be done later on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #9