Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion launch/model_endpoint.py
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ def get(self, timeout: Optional[float] = None) -> EndpointResponse:
client=self.client,
status=status,
result_url=None,
result=None,
result=async_response.get("result", None),
traceback=async_response.get("traceback", None),
status_code=async_response.get("status_code", None),
)
Expand Down
42 changes: 42 additions & 0 deletions tests/test_model_endpoint.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,3 +75,45 @@ def test_status_returns_updated_value(requests_mock): # noqa: F811
response=HTTPResponse(body=json.dumps(resp), status=200)
)
assert endpoint.status() == "SUCCESS"


def test_endpoint_response_future_failure_preserves_result():
"""FAILURE responses should expose the result string (stringified exception) from the server."""
mock_client = MagicMock()
mock_client._get_async_endpoint_response.return_value = {
"status": "FAILURE",
"result": "Out of memory",
"traceback": "Traceback (most recent call last): ...\nRuntimeError: Out of memory",
"status_code": 500,
}

from launch.model_endpoint import EndpointResponseFuture

future = EndpointResponseFuture(mock_client, "test-endpoint", "task-123")
response = future.get()

assert response.status == "FAILURE"
assert response.status_code == 500
assert response.result == "Out of memory"
assert response.traceback == "Traceback (most recent call last): ...\nRuntimeError: Out of memory"
assert response.result_url is None


def test_endpoint_response_future_failure_no_result_body():
"""FAILURE responses with no result body should still work (e.g. pod crash with no response)."""
mock_client = MagicMock()
mock_client._get_async_endpoint_response.return_value = {
"status": "FAILURE",
"result": None,
"traceback": None,
"status_code": 500,
}

from launch.model_endpoint import EndpointResponseFuture

future = EndpointResponseFuture(mock_client, "test-endpoint", "task-456")
response = future.get()

assert response.status == "FAILURE"
assert response.result is None
assert response.traceback is None