-
Notifications
You must be signed in to change notification settings - Fork 73
feat(gcp): enable GCP auth support — Redis cache URL + DB credentials #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e521efe
feat(gcp): add cache_redis_gcp_url for GCP Memorystore support
lilyz-ai 73e6b39
docs: use example IP in GCP Memorystore cache_redis_gcp_url sample
lilyz-ai 965c8cc
feat(vllm): update standard vllm image to 0.17.0 to support Qwen3.5
lilyz-ai 15470db
feat(gcp): add GCP branch in get_engine_url for Cloud SQL via env vars
lilyz-ai 9e18d0a
revert(charts): keep vllm default tag as latest in values.yaml
lilyz-ai 887ff1a
Merge branch 'main' into lilyzhu/gcp-auth-support
lilyz-ai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hostwill beNonewhenDB_HOST_ROis unsetWhen
read_only=Trueand theDB_HOST_ROenvironment variable is not set,os.environ.get("DB_HOST_RO")returnsNone, sohostwill beNone. This produces a broken connection string that will fail at connection time.The on-prem branch on line 65 handles this correctly with an
orfallback:The GCP branch should use the same fallback pattern to avoid
Nonehosts:Or more simply, match the on-prem pattern exactly if the
read_onlydistinction is not required.Prompt To Fix With AI