CLDSRV-872: store checksum in object metadata

[leif-scality]

No description provided.

[bert-e]

Hello leif-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue CLDSRV-872 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 9.4.0

Please check the Fix Version/s of CLDSRV-872, or the target
branch of this pull request.

[codecov]

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
8450	2	8448	0

View the top 2 failed test(s) by shortest run time

"after each" hook for "should replicate/put metadata to a destination that has a suspended null version with internal version"::backbeat routes for replication (cross account) "after each" hook for "should replicate/put metadata to a destination that has a suspended null version with internal version"

Stack Traces | 0.067s run time

The bucket you tried to delete is not empty.

"after each" hook for "should replicate/put metadata to a destination that has a null version"::backbeat routes for replication (same account) "after each" hook for "should replicate/put metadata to a destination that has a null version"

Stack Traces | 0.097s run time

The bucket you tried to delete is not empty.

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[claude]

• Arsenal dependency is pinned to a branch instead of a tag. Must be pinned to a release tag before merging.
  • Change arsenal in package.json to point to a tagged version.
• Verify ObjectMDChecksum constructor argument names match the field names used in storeObject.js checkHashMatchMD5 (algorithm, value, type). The unit tests assert checksumAlgorithm, checksumValue, checksumType on the stored metadata. If ObjectMDChecksum maps these internally it is fine, but worth confirming.
• In storeObject.js dataStore, the onStreamError handler (line 91) and doValidate via once('finish', ...) (line 125) can both fire if the stream emits both error and finish. jsutil.once(cb) prevents a double callback, but both paths would call batchDelete independently. Consider removing the opposing listener when one fires to avoid a redundant delete call.

Review by Claude Code

[claude]

Review summary: (1) Arsenal dependency pinned to a branch instead of a tag - must update to a released tag. (2) checkHashMatchMD5 JSDoc missing the new checksumStream parameter. (3) dataStore callback returns a 4th checksum arg but objectPutPart and routeBackbeat callers ignore it. -- Review by Claude Code

[claude]

• Arsenal dependency is pinned to a branch instead of a tag, which makes builds non-reproducible. Pin to a released tag before merging.
  
  Review by Claude Code

[claude]

• Arsenal dependency is pinned to a feature branch instead of a release tag. Pin to a tag before merging.
  
  Review by Claude Code

[claude]

• Arsenal is pinned to a feature branch instead of a release tag. This must be updated to a tagged version before merging to ensure reproducible builds.
  
  Review by Claude Code

[claude]

• Arsenal dependency is pinned to a branch instead of a tag. Must be updated to a released tag before merge.
• Misleading comment placement in routeBackbeat.js (two places): the checksum 4th-arg comment sits between dataStore positional args. Move it above the callback.

Review by Claude Code

[claude]

• Arsenal dependency is pinned to a feature branch instead of a release tag. Must be updated to a tagged version before merging.
  • Pin to the release tag that includes the ObjectMDChecksum changes.
• zeroSizeBodyChecksumCheck mixes callbacks with Promises, creating a double-callback risk: if callback throws inside .then(), the .catch() will invoke callback(err) a second time.
  • Use process.nextTick inside the .then() and .catch() to break out of the promise chain, or convert to async/await with try/catch.

Review by Claude Code

[claude]

• Arsenal dependency is pinned to a branch instead of a tag. This must be updated to a release tag before merging for reproducible builds.

Review by Claude Code

[claude]

• Arsenal dependency is pinned to a feature branch instead of a release tag. Must be updated to a tag before merge.
  
  Review by Claude Code

[claude]

LGTM

Review by Claude Code

[BourgoisMickael]

prefer starting with should