S3UTILS-222 Tool to update CRR policies#376
Closed
Copilot wants to merge 2 commits intoimprovement/S3UTILS-222/check-replication-permissionsfrom
Closed
S3UTILS-222 Tool to update CRR policies#376Copilot wants to merge 2 commits intoimprovement/S3UTILS-222/check-replication-permissionsfrom
Copilot wants to merge 2 commits intoimprovement/S3UTILS-222/check-replication-permissionsfrom
Conversation
Co-authored-by: nicolas2bert <7453636+nicolas2bert@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add tool to update CRR policies
S3UTILS-222 Tool to update CRR policies
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a replicationAudit toolset to audit and fix missing
s3:ReplicateObjectpermissions on CRR roles.New scripts
list-buckets-with-replication.sh— Discovers all buckets with replication enabled via bucketd metadata APIcheck-replication-permissions.js— Checks each replication role's attached policies fors3:ReplicateObjectby querying Vault metadata directly via repd protocol (no credentials needed)fix-missing-replication-permissions.js— Creates and attaches IAM policies withs3:ReplicateObjectfor roles missing it, using temporary account access keys with 15-minute auto-expiryKey design choices
CreatePolicyreuse viaEntityAlreadyExistsExceptionhandling;AttachRolePolicyis a no-op if already attacheds3-replication-audit-fix-<roleName>, scoped only to affected bucket ARNs--dry-runmode for safe pre-flight checksprocess.exit(0)after completion to avoid hanging on keepAlive HTTP agentsOther changes
@aws-sdk/client-iamfromdevDependenciestodependencies(now used in production script)check-replication-permissions.jsoutput now includesownerDisplayName(breaking change, documented)deleteTestAccountupdated to handle multi-bucket cleanup and policy deletionpolicyAllowsReplication(24 cases) and functional tests covering dry-run, idempotency, multi-bucket, multi-role, and cross-account scenarios💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.