Skip to content

S3UTILS-225 [impr] list bucketd versions with full metadata#379

Open
jonathan-gramain wants to merge 2 commits intodevelopment/1.16from
improvement/S3UTILS-225-list-bucketd-versions-full-metadata
Open

S3UTILS-225 [impr] list bucketd versions with full metadata#379
jonathan-gramain wants to merge 2 commits intodevelopment/1.16from
improvement/S3UTILS-225-list-bucketd-versions-full-metadata

Conversation

@jonathan-gramain
Copy link
Contributor

Create a new helper function that returns an async iterator on a bucket versions listing via bucketd, fetching the full locations array when it is pruned from the listing results.

It ensures to fetch the full metadata (including all locations) from the correct version, trying the different possible URLs for the specific case of null versions.

Note: unfortunately we don't have a clean high-level API in bucketd to do this, Cloudserver is normally doing this preprocessing to build the correct bucketd URL to fetch.

@bert-e
Copy link
Contributor

bert-e commented Mar 9, 2026

Hello jonathan-gramain,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Mar 9, 2026

Incorrect fix version

The Fix Version/s in issue S3UTILS-225 contains:

  • 1.17.5

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.15.14

  • 1.16.6

  • 1.17.5

  • 1.18.0

Please check the Fix Version/s of S3UTILS-225, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Mar 9, 2026

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@jonathan-gramain jonathan-gramain force-pushed the improvement/S3UTILS-225-list-bucketd-versions-full-metadata branch from cb0af75 to a3725b7 Compare March 9, 2026 11:31
@jonathan-gramain jonathan-gramain force-pushed the improvement/S3UTILS-225-list-bucketd-versions-full-metadata branch from a3725b7 to a46e3e6 Compare March 10, 2026 16:46
@bert-e
Copy link
Contributor

bert-e commented Mar 10, 2026

Incorrect fix version

The Fix Version/s in issue S3UTILS-225 contains:

  • 1.15.14

  • 1.16.6

  • 1.17.5

  • 1.18.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.15.14

  • 1.16.6

  • 1.17.6

  • 1.18.0

Please check the Fix Version/s of S3UTILS-225, or the target
branch of this pull request.

@jonathan-gramain jonathan-gramain changed the base branch from development/1.15 to development/1.16 March 10, 2026 16:47
@bert-e
Copy link
Contributor

bert-e commented Mar 10, 2026

Incorrect fix version

The Fix Version/s in issue S3UTILS-225 contains:

  • 1.15.14

  • 1.16.6

  • 1.17.5

  • 1.18.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.16.6

  • 1.17.6

  • 1.18.0

Please check the Fix Version/s of S3UTILS-225, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Mar 10, 2026

Incorrect fix version

The Fix Version/s in issue S3UTILS-225 contains:

  • 1.16.6

  • 1.17.5

  • 1.18.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.16.6

  • 1.17.6

  • 1.18.0

Please check the Fix Version/s of S3UTILS-225, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Mar 10, 2026

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

Create a new helper function that returns an async iterator on a
bucket versions listing via bucketd, fetching the full locations array
when it is pruned from the listing results.

It ensures to fetch the full metadata (including all locations) from
the correct version, trying the different possible URLs for the
specific case of null versions.

Note: unfortunately we don't have a clean high-level API in bucketd to
do this, Cloudserver is normally doing this preprocessing to build the
correct bucketd URL to fetch.
@jonathan-gramain jonathan-gramain force-pushed the improvement/S3UTILS-225-list-bucketd-versions-full-metadata branch from a46e3e6 to da19184 Compare March 13, 2026 11:01
@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 97.05882% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.59%. Comparing base (38ff109) to head (8ab54e6).

Files with missing lines Patch % Lines
utils/async/bucketd/listVersions.js 95.89% 3 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           development/1.16     #379      +/-   ##
====================================================
+ Coverage             43.65%   44.59%   +0.93%     
====================================================
  Files                    82       84       +2     
  Lines                  5717     5819     +102     
  Branches               1208     1237      +29     
====================================================
+ Hits                   2496     2595      +99     
- Misses                 3176     3179       +3     
  Partials                 45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@tcarmet tcarmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit comment, but LGTM

@jonathan-gramain jonathan-gramain force-pushed the improvement/S3UTILS-225-list-bucketd-versions-full-metadata branch from 6824c13 to 8ab54e6 Compare March 25, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants