ci: merge coverage with regular CI tests#116
ci: merge coverage with regular CI tests#116Borda wants to merge 3 commits intoscientific-python:mainfrom
Conversation
|
We have the separate because we run the tests on multiple platforms and multiple python versions, but we only want to run coverage reports on one platform and one python version. This is the standard pattern on most Scientific Python projects. |
I see, but with Codecov, id does a fusion of all received reports for a particular commit, and with the newly added flags/tags, you can validate what lines are visited only for a specific configuration... Anyway, just a suggestion, and feel free to close it :) |
|
@jarrodmillman, mind have a look or feel free to close it... :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
==========================================
- Coverage 96.00% 89.60% -6.41%
==========================================
Files 5 5
Lines 250 250
==========================================
- Hits 240 224 -16
- Misses 10 26 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This would really only be worth it if we had different jobs that covered different things. I don't see any coverage gaps that couldn't be handled by a couple more tests and mocking the environment, so I'm going to close this. |
This could simplify maintenance as the testing and reporting coverage workflows are almost the same, so let's add reporting coverage to the main one and drop the additional/duplicate...