Closed
Conversation
❌ Deploy Preview for scientific-python-org failed.Built without sensitive environment variables
|
Member
agriyakhetarpal
left a comment
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Thanks, @goanpeca! I went through the changes and this one is a little different from the rest of them as I noticed that the closing >}} tags are not on a new line – is this because there is something that needs be reworked in our PR upstream w.r.t these TOML tables? Having the closing tags on the same line is also fine to me, so I was just curious about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello team!
As part of figure, image and button shortcodes as being updated on scientific-python/scientific-python-hugo-theme#674 I created this PR to prepare the website for moving to the new syntax when a new version is released!
Pinging @agriyakhetarpal