Skip to content

Fixes for conda #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
finsberg wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fixes for conda #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9584d9f
Lower absolute tolerance in vtkhdf tests
finsberg Feb 19, 2026
835e240
Wait for engines, see https://github.com/ipython/ipyparallel/pull/501
finsberg Feb 19, 2026
848fae2
More fixes for tolerance in vtkhdf
finsberg Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ def backend(request):
def cluster():
cluster = ipp.Cluster(engines="mpi", n=2)
rc = cluster.start_and_connect_sync()
rc.wait_for_engines(n=2)
yield rc
cluster.stop_cluster_sync()

Expand Down
16 changes: 8 additions & 8 deletions tests/test_vtkhdf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def test_write_point_data(dtype, tmp_path, cell_type):
filename=filename, name="u", mesh=grid, time=tj, backend="vtkhdf"
)
v_ref = Function(u.function_space, dtype=u.x.array.dtype)
atol = 10 * np.finfo(u.x.array.dtype).eps
atol = 15 * np.finfo(u.x.array.dtype).eps
v_ref.interpolate(lambda x: f(x, tj))
np.testing.assert_allclose(u.x.array, v_ref.x.array, atol=atol)

Expand All @@ -124,7 +124,7 @@ def test_write_point_data(dtype, tmp_path, cell_type):
filename=blocked_file, name="u", mesh=grid, time=tk, backend="vtkhdf"
)
v_ref = Function(u.function_space, dtype=u.x.array.dtype)
atol = 10 * np.finfo(u.x.array.dtype).eps
atol = 15 * np.finfo(u.x.array.dtype).eps
v_ref.interpolate(lambda x: g(x, tk))
np.testing.assert_allclose(u.x.array, v_ref.x.array, atol=atol)

Expand Down Expand Up @@ -160,7 +160,7 @@ def test_write_cell_data(dtype, tmp_path, cell_type):
filename=filename, name="u", mesh=grid, time=tj, backend="vtkhdf"
)
v_ref = Function(u.function_space, dtype=u.x.array.dtype)
atol = 10 * np.finfo(u.x.array.dtype).eps
atol = 15 * np.finfo(u.x.array.dtype).eps
v_ref.interpolate(lambda x: f(x, tj))
np.testing.assert_allclose(u.x.array, v_ref.x.array, atol=atol)

Expand All @@ -179,7 +179,7 @@ def test_write_cell_data(dtype, tmp_path, cell_type):
filename=blocked_file, name="u", mesh=grid, time=tk, backend="vtkhdf"
)
v_ref = Function(u.function_space, dtype=u.x.array.dtype)
atol = 10 * np.finfo(u.x.array.dtype).eps
atol = 15 * np.finfo(u.x.array.dtype).eps
v_ref.interpolate(lambda x: g(x, tk))
np.testing.assert_allclose(u.x.array, v_ref.x.array, atol=atol)

Expand Down Expand Up @@ -254,7 +254,7 @@ def test_write_meshtags(dtype, tmp_path, generate_reference_map):
)
org_maps[dim] = generate_reference_map(mesh, et, comm, root)

tol = 10 * np.finfo(dtype).eps
tol = 15 * np.finfo(dtype).eps
# Read in hex grid from second time step
hex_mesh = io4dolfinx.read_mesh(
filename, comm, time=1.0, backend_args={"name": "hex"}, backend="vtkhdf"
Expand Down Expand Up @@ -288,7 +288,7 @@ def test_write_meshtags(dtype, tmp_path, generate_reference_map):

@pytest.mark.parametrize("dtype", [np.float32, np.float64])
def test_read_write_pointdata(dtype, tmp_path):
tol = 10 * np.finfo(dtype).eps
tol = 15 * np.finfo(dtype).eps

comm = MPI.COMM_WORLD
tmp_path = comm.bcast(tmp_path, root=0)
Expand Down Expand Up @@ -360,7 +360,7 @@ def f(x, t):

@pytest.mark.parametrize("dtype", [np.float32, np.float64])
def test_read_write_celldata(dtype, tmp_path):
tol = 10 * np.finfo(dtype).eps
tol = 15 * np.finfo(dtype).eps

comm = MPI.COMM_WORLD
tmp_path = comm.bcast(tmp_path, root=0)
Expand Down Expand Up @@ -436,7 +436,7 @@ def f(x, t):

@pytest.mark.parametrize("dtype", [np.float32, np.float64])
def test_read_write_mix_data(dtype, tmp_path):
tol = 10 * np.finfo(dtype).eps
tol = 15 * np.finfo(dtype).eps

mesh = create_unit_square(MPI.COMM_WORLD, 5, 7, dtype=dtype)

Expand Down