feat: add tracesSampler callback and integrations array to SentryConfig#5
Merged
feat: add tracesSampler callback and integrations array to SentryConfig#5
Conversation
benminer
added a commit
that referenced
this pull request
Apr 13, 2026
- types.ts: derive SentryIntegration via ReturnType<typeof Sentry.expressIntegration> instead of fragile Extract<NodeOptions['integrations'], unknown[]>[number] - config.ts: clamp tracesSampler return value through clampSampleRate(), consistent with how sampleRate is handled - provider.ts: extract tracesSampler composition into exported buildTracesSampler() so the logic can be unit-tested directly - filtering.test.ts: replace duplicated makeSampler local copy with buildTracesSampler from the real implementation, so tests actually cover provider.ts logic
benminer
added a commit
that referenced
this pull request
Apr 13, 2026
* feat!: upgrade OpenTelemetry to 2.x, bump to v2.0.0
- sdk-trace-node ^1.25.0 → ^2.6.1
- resources ^1.25.0 → ^2.6.1
- exporter-trace-otlp-http ^0.52.0 → ^0.214.0
- semantic-conventions ^1.25.0 → ^1.40.0
OTEL 2.x API changes applied:
- new Resource({}) → resourceFromAttributes() factory function
- provider.addSpanProcessor() → spanProcessors: [] in constructor config
- SEMRESATTRS_DEPLOYMENT_ENVIRONMENT → ATTR_DEPLOYMENT_ENVIRONMENT_NAME
from @opentelemetry/semantic-conventions/incubating (changes resource
attribute key from deployment.environment to deployment.environment.name)
Fixes the sdk-trace-base version mismatch crash seen in downstream
consumers that pin OTEL packages to 2.x globally.
* fix: address code review findings from PR #5
- types.ts: derive SentryIntegration via ReturnType<typeof Sentry.expressIntegration>
instead of fragile Extract<NodeOptions['integrations'], unknown[]>[number]
- config.ts: clamp tracesSampler return value through clampSampleRate(), consistent
with how sampleRate is handled
- provider.ts: extract tracesSampler composition into exported buildTracesSampler()
so the logic can be unit-tested directly
- filtering.test.ts: replace duplicated makeSampler local copy with buildTracesSampler
from the real implementation, so tests actually cover provider.ts logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new optional fields to
SentryConfigto unblock the backend monorepo migration from direct Sentry/Pyroscope initialization toobservability-js.tracesSampler— custom sampling callback invoked after the built-inignoredRoutescheck and before the defaultsampleRatefallback. Returnsnumber | undefined; returningundefinedfalls through tosampleRate. Enables the backend to suppress traces for specific customers (e.g. QAWolf test accounts) without patching the library.integrations— array of additional Sentry integrations spread after the hardcoded defaults (expressIntegration,nodeProfilingIntegration). Enables consumers to registerprismaIntegration(),rewriteFramesIntegration(), etc.Both fields flow unchanged through
resolveConfigintoResolvedConfig.sentry. Types are derived from the already-declared@sentry/nodedependency viaNodeOptionsutility types — no new imports or dependencies added.Also relaxes
engines.nodefrom>= 24to>= 20so the package installs cleanly on backends not yet on Node 24 (.nvmrcstays at 24 for local dev).Testing
5 new tests in
filtering.test.tscover the sampler composition logic:sampleRatewhen no custom sampler is providedsampleRateundefinedreturn falls through tosampleRateignoredRoutesshort-circuits before the custom sampler is called