io: Fix crash on SDL joystick disconnect#7216
Open
laanwj wants to merge 1 commit intoscp-fs2open:masterfrom
Open
io: Fix crash on SDL joystick disconnect#7216laanwj wants to merge 1 commit intoscp-fs2open:masterfrom
laanwj wants to merge 1 commit intoscp-fs2open:masterfrom
Conversation
Check that `pJoystick[i]` is non-null before dereferencing it.
wookieejedi
added
fix
Member
|
Even though it is a 1-line fix, it would be good to have @z64555 take a look, too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a crash on joystick disconnection by checking that
pJoystick[i]is non-null before dereferencing it.(im running into this regularly while disconnecting the session in moonlight/sunshine, which removes a bunch of virtual libevent devices)